Fix PR builds that are failing due to "broken links"#2142
Merged
dscho merged 1 commit intogit:gh-pagesfrom Mar 7, 2026
Merged
Conversation
These errors seem to have been with us since February 28th, 2026, which was when lychee 0.23.0 was used for the PR build for the first time: https://github.com/git/git-scm.com/actions/runs/22511224516/job/65220662173#step:15:70 [...] ### Errors in public/application.min.85d33c919f3ff9788e84d1be0d991a68627af6191d5d6ce65ac9a1216a11e585.css Error: * [ERROR] <error:> | Error building URL for "/images/bg/body.jpg" (Attribute: Some("url")): Cannot convert path '/images/bg/body.jpg' to a URI: To resolve root-relative links in local files, provide a root dir Error: * [ERROR] <error:> | Error building URL for "/images/bg/body.jpg" (Attribute: Some("url")): Cannot convert path '/images/bg/body.jpg' to a URI: To resolve root-relative links in local files, provide a root dir Error: * [ERROR] <error:> | Error building URL for "/images/bg/isometric-grid.png" (Attribute: Some("url")): Cannot convert path '/images/bg/isometric-grid.png' to a URI: To resolve root-relative links in local files, provide a root dir [...] The preceding PR build succeeded on February 23rd, 2026: https://github.com/git/git-scm.com/actions/runs/22313554003/job/64551960417#step:15:70 (it used lychee 0.21.0, still). There haven't been any announcements of breaking changes in the 0.22.0 nor in the 0.23.0 release notes that would talk about `--root-dir` being required (https://github.com/lycheeverse/lychee/releases), but it is now obviously required. This only affected the PR builds because we already use the `--root-dir` option in the deployment pipeline (to work around issues stemming from absolute URL path prefixes being required in forks). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
lychee0.23.0.Context
Since February 28th, 2026, our PR builds are failing consistently (which I noticed only today):
The reason is not that all of a sudden, this project only receives crappy contributions. The reason is that a silent upgrade of
lycheeto 0.23.0 (which did not require a separate upgrade of thelycheeGitHub Action, apparently) now makes the use of--root-dirmandatory when referring to absolute paths in, say, the.cssfiles.The symptom looks like this:
Simply providing a
--root-diroption fixes this.